[Webkit-unassigned] [Bug 62451] [EFL] open keyIdentifierForEvasKeyName and windowsKeyCodeForEvasKeyName to use in the WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62451





--- Comment #3 from EunMi Lee <eunmi15.lee at samsung.com>  2011-06-12 19:27:49 PST ---
(In reply to comment #2)
> (From update of attachment 96738 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96738&action=review
> 
> > Source/WebCore/platform/PlatformKeyboardEvent.h:214
> > +
> > +        // Used by WebKit2
> > +        static String keyIdentifierForEvasKeyName(String&);
> > +        static int windowsKeyCodeForEvasKeyName(String&);
> 
> Do we really need this? What if WebKit2 is not used? I know GTK is using a similar approach to this, but maybe there's a better approach?

Yes, I really need this because we have to copy all codes for KeyMap (createKeyMap(), createWindowKeyMap()) to the WebKit2 efl port without this.
And I think that this code will not raise any problem without WebKit2.
About a better approach,
I think it is better to unite WebKit1's PlatformKeyboardEvent and WebKit2's NativeWebKeyboardEvent but it is hard to me because that will cause modifications of all ports's KeyboardEvent.
I will be grateful if you share your idea about that :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.