[Webkit-unassigned] [Bug 61915] [EFL][WK2] Add efl port's ewk_view files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 12 18:55:47 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61915





--- Comment #27 from EunMi Lee <eunmi15.lee at samsung.com>  2011-06-12 18:55:46 PST ---
(In reply to comment #26)
> (From update of attachment 96736 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96736&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:380
> > +Eina_Bool ewk_view_smart_set(Ewk_View_Smart_Class* api)
> 
> Shouldn't this be called ewk_view_smart_class_init() or something like this?

ewk_view_smart_set() is called in the _ewk_view_smart_class_new().
We have to fill the Smart_Class functions and Ewk APIs before we create Evas_Smart using evas_smart_class_new().
ewk_view_smart_set()'s codes can be resident in the _ewk_view_smart_class_new() function, but I made that as a separate function for readability.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list