[Webkit-unassigned] [Bug 62518] If an Event Listener is a Function, It Should be Called and Not Checked for handleEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62518





--- Comment #3 from Dominic Cooney <dominicc at chromium.org>  2011-06-12 18:29:36 PST ---
(From update of attachment 96893)
View in context: https://bugs.webkit.org/attachment.cgi?id=96893&action=review

While I am not a reviewer, it would be nice if this patch included a ChangeLog and a layout test.

I think the layout test in a previous attachment could be much more succinct if it briefly (one sentence) described what it was testing and used the JS test framework many other layout tests use.

> Source/WebCore/bindings/js/JSEventListener.cpp:100
> +    CallType callType = jsFunction->getCallData(callData);

Is it safe to use this getCallData here, c.f. the two-argument helper in the original? I think that the checks are slightly different.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.