[Webkit-unassigned] [Bug 55455] [EFL] HTML saving feature

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55455





--- Comment #27 from Antonio Gomes <tonikitoo at webkit.org>  2011-06-10 21:49:42 PST ---
(From update of attachment 94577)
View in context: https://bugs.webkit.org/attachment.cgi?id=94577&action=review

> Source/WebKit/efl/ewk/ewk_frame.cpp:2014
> + * It's part of html saving feature. Currently only HTML documents are supported.

html x HTML

> Source/WebKit/efl/ewk/ewk_frame.cpp:2036
> +        WRN("Only html documents are supported");

HTML

> Source/WebKit/efl/ewk/ewk_frame.cpp:2041
> +    WebCore::Node* de = sd->frame->document()->documentElement();

de -> documentElement

> Source/WebKit/efl/ewk/ewk_frame.cpp:2043
> +        for (WebCore::Node* e = de->firstChild(); e; e = e->parentElement()) {

e -> node or currentNode or whatever more descriptive.

> Source/WebKit/efl/ewk/ewk_frame.cpp:2099
> +        WebCore::HTMLImageElement* img_element = static_cast<WebCore::HTMLImageElement*>(images->item(index));

camel case -> imageElement?

> Source/WebKit/efl/ewk/ewk_frame.cpp:2103
> +        WTF::String img_location = img_element->src().prettyURL();

Ditto.

> Source/WebKit/efl/ewk/ewk_frame.cpp:2105
> +        Eina_List* l = 0;

l -> listOfXXX

> Source/WebKit/efl/ewk/ewk_frame.cpp:2115
> +        if (!duplicate)

duplicate -> imageLocationCopy?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.