[Webkit-unassigned] [Bug 44505] [EFL] Missing plugins support for efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44505





--- Comment #29 from Antonio Gomes <tonikitoo at webkit.org>  2011-06-10 12:06:45 PST ---
(From update of attachment 96740)
View in context: https://bugs.webkit.org/attachment.cgi?id=96740&action=review

Looks fine. Some nits ...

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:101
> +    IntRect p = static_cast<FrameView*>(parent())->contentsToScreen(IntRect(0, 0, event->offsetX(), event->offsetY()));

Use a more descriptive name than p

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:112
> +        xEvent.xbutton.button = event->button() + 1; // DOM MouseEvent counts from 0, and XButtonEvent from 1

add . at the end.

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:190
> +    if (parent)
> +        init();
> +    else if (!platformPluginWidget())
> +        return;

do you need a return here? or a else-if then return?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.