[Webkit-unassigned] [Bug 53627] Inspector highlight rect is wrong for contents of transformed iframes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 10 11:30:45 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=53627





--- Comment #11 from Joseph Pecoraro <joepeck at webkit.org>  2011-06-10 11:30:45 PST ---
(In reply to comment #9)
> > Source/WebCore/rendering/RenderObject.cpp:1876
> > +    // Account for the border of the frame renderer if we are mapping content inside the container.
> > +    transformState.move(o->borderLeft(), o->borderTop());
> > +    static_cast<RenderObject*>(o)->mapLocalToContainer(0, fixed, useTransforms, transformState);
> 
> I think this should be done with some combination of FrameView::convertFromRenderer(),
> convertToContainingView(), and convertToWindow(). I think you code here is ignoring
> padding, and might not work with scrolled content.

The problem I was having with those was that many of those use IntRects. The desired result
for the Inspector code was a FloatQuad. IntRects for instance cannot be used for rotated content.
I think I can switch to the functions you mention above, if there a way that I can then apply all
the transforms that would affect that resulting IntRect. Do you know offhand if there is an
existing way to do that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list