[Webkit-unassigned] [Bug 53627] Inspector highlight rect is wrong for contents of transformed iframes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 10 10:39:33 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=53627





--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-06-10 10:39:33 PST ---
(From update of attachment 96755)
View in context: https://bugs.webkit.org/attachment.cgi?id=96755&action=review

> Source/WebCore/rendering/RenderObject.cpp:1868
> +void RenderObject::mapContainerToWindow(bool fixed, bool useTransforms, TransformState& transformState) const

I'm not sure that I like having RenderObject having any knowledge of window-level things.

> Source/WebCore/rendering/RenderObject.cpp:1876
> +    // Account for the border of the frame renderer if we are mapping content inside the container.
> +    transformState.move(o->borderLeft(), o->borderTop());
> +    static_cast<RenderObject*>(o)->mapLocalToContainer(0, fixed, useTransforms, transformState);

I think this should be done with some combination of FrameView::convertFromRenderer(), convertToContainingView(), and convertToWindow(). I think you code here is ignoring padding, and might not work with scrolled content.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list