[Webkit-unassigned] [Bug 62422] TiledBackingStore endlessly creates and destroys tiles due to an off-by-one error.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62422





--- Comment #6 from Darin Adler <darin at apple.com>  2011-06-10 09:23:24 PST ---
(From update of attachment 96723)
View in context: https://bugs.webkit.org/attachment.cgi?id=96723&action=review

> Source/WebCore/platform/graphics/TiledBackingStore.cpp:80
>      Tile::Coordinate topLeft = tileCoordinateForPoint(dirtyRect.location());
> -    Tile::Coordinate bottomRight = tileCoordinateForPoint(IntPoint(dirtyRect.maxX(), dirtyRect.maxY()));
> +    Tile::Coordinate bottomRight = tileCoordinateForPoint(IntPoint(dirtyRect.maxX() - 1, dirtyRect.maxY() - 1));
>      
>      for (unsigned yCoordinate = topLeft.y(); yCoordinate <= bottomRight.y(); ++yCoordinate) {
>          for (unsigned xCoordinate = topLeft.x(); xCoordinate <= bottomRight.x(); ++xCoordinate) {

I think a bette fix would be to change the <= into a < rather than changing the value in bottomRight.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.