[Webkit-unassigned] [Bug 61205] Web Inspector: Cache XHR content in backend, do not use initialContentSet for XHRs.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61205





--- Comment #21 from Andrey Kosyakov <caseq at chromium.org>  2011-06-10 06:34:51 PST ---
(From update of attachment 96741)
View in context: https://bugs.webkit.org/attachment.cgi?id=96741&action=review

A couple of nits, but otherwise looks good. Yury & Pavel, please have a look.

> Source/WebCore/inspector/NetworkResourcesData.cpp:128
> +    m_identifierToResourceDataMap.clear();

This is redundant.

> Source/WebCore/inspector/NetworkResourcesData.h:45
> +        ~ResourceData() { }

Why do we need this?

> Source/WebCore/inspector/NetworkResourcesData.h:73
> +    HashMap<unsigned long, ResourceData*> m_identifierToResourceDataMap;

nit: it might be worth having a typedef for this, given that it's used in a few other places.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.