[Webkit-unassigned] [Bug 62445] [EFL][WK2] Add dummy files at below of WebProcess.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 10 04:19:48 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=62445


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96725|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-06-10 04:19:48 PST ---
(From update of attachment 96725)
View in context: https://bugs.webkit.org/attachment.cgi?id=96725&action=review

> Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp:33
> +    // FIXME: Not implemented.

why not use notImplemented() ? please do that

> Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:42
> +    ASSERT(argc == 2);

Why not handle it instead

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list