[Webkit-unassigned] [Bug 57820] [GTK] Export an API similar to WebKit1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 10 03:54:04 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=57820
--- Comment #20 from WebKit Review Bot <webkit.review.bot at gmail.com> 2011-06-10 03:54:04 PST ---
Attachment 96727 did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:52: Extra space before ( in function call [whitespace/parens] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:53: Extra space before ( in function call [whitespace/parens] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:54: Extra space before ( in function call [whitespace/parens] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:55: Extra space before ( in function call [whitespace/parens] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:56: Extra space before ( in function call [whitespace/parens] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:57: Extra space before ( in function call [whitespace/parens] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:58: Extra space before ( in function call [whitespace/parens] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:59: Extra space before ( in function call [whitespace/parens] [4]
Source/WebKit2/UIProcess/API/gtk/webkit/webkit.h:20: #ifndef header guard has wrong style, please use: WTF_webkit_h [build/header_guard] [5]
Source/WebKit2/UIProcess/API/gtk/webkit/webkit.h:25: Alphabetical sorting problem. [build/include_order] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:34: webkit_web_view_init is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:39: webkit_web_view_class_init is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:49: webkit_web_view_load_uri is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:58: webkit_web_view_go_back is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:66: webkit_web_view_go_forward is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 15 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list