[Webkit-unassigned] [Bug 62346] [EFL][WK2] Add dummy files in WebProcess/WebCoreSupport/efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62346





--- Comment #3 from Ryuan Choi <ryuan.choi at samsung.com>  2011-06-10 03:00:07 PST ---
(In reply to comment #2)
> (From update of attachment 96528 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96528&action=review
> 
> As with other WebKit2 patches, I'm mostly reviewing for style issues, as I'm not familiar with WebKit2 yet.
> 
> WebEditorClientEfl.cpp doesn't use anything EFL-related (and I couldn't see any EFL-specific behaviour there, too). Is it possible to share this code with other WebKit2 ports?
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:44
> > +bool WebEditorClient::executePendingEditorCommands(Frame* frame, Vector<WTF::String> pendingEditorCommands, bool allowTextInsertion)
> > +{
> > +    Vector<Editor::Command> commands;
> > +    for (size_t i = 0; i < pendingEditorCommands.size(); i++) {
> 
> I'd use Vector::iterator here (Vector::begin(), Vector::end(), etc), for both pendingEditorCommands and commands.

We referenced WebKit2/Gtk and I realized that this code only used for Gtk.(Anyway it looks fine for Efl.)
I think that It's better to removed for initial drop and investigate more.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.