[Webkit-unassigned] [Bug 61272] [Chromium] On-the-spot IME support for windowless plug-ins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61272





--- Comment #9 from Kent Tamura <tkent at chromium.org>  2011-06-10 01:59:31 PST ---
(In reply to comment #7)
> > We had better use wtf/text/StringBuilder.
> 
> If I recall correctly, it is not so simple to append text to a StringBuffer object as this code does. (I could be wrong, though.) Since this code is used only when we type text with an IME, I'm a little wondering if we use StringBuffer here and make this code more complicated. Would it be possible to give me a good idea that can use StringBuffer without losing simplicity?

I'm not sure what you are worrying about.  I think this code can be written with StringBuilder in similar amount of code.
String::append() and operator+= replace an internal StringImpl.  We had better avoid use them.

Also, we have makeString() in wtf/text/StringConcatenate.h.  It might make the code simpler.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.