[Webkit-unassigned] [Bug 61556] REGRESSION(87152): Crash on page with svg fonts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61556


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96692|review?                     |review-
               Flag|                            |




--- Comment #10 from Dirk Schulze <krit at webkit.org>  2011-06-10 00:05:25 PST ---
(From update of attachment 96692)
View in context: https://bugs.webkit.org/attachment.cgi?id=96692&action=review

This definitely needs a crash and regression test (both can be one test in this case).

> Source/WebCore/ChangeLog:9
> +        We can't assume that the parent of a SVG-font-styled
> +        text node won't be an anonymous block.
> +        http://bugs.webkit.org/show_bug.cgi?id=61556
> +
> +        No new tests. (OOPS!)

The style is wrong:

bugtitle
bugURL

text

> Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:-80
> -    ASSERT(newRenderer->node());
> -    ASSERT(newRenderer->node()->isElementNode());

Why did you remove these asserts?

> Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:270
> +        String language;

What happens if language is empty? Seems that we assumed that we have lang set.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.