[Webkit-unassigned] [Bug 62260] [CMAKE][WK2] Add an option to build webkit2.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62260





--- Comment #18 from Ryuan Choi <ryuan.choi at samsung.com>  2011-06-09 17:30:45 PST ---
(In reply to comment #16)
> (From update of attachment 96563 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96563&action=review
> 
> > Source/CMakeLists.txt:29
> > +IF (ENABLE_WEBKIT2)
> > +    SET(WEBKIT2_DIR "${CMAKE_SOURCE_DIR}/WebKit2")
> > +    SET(DERIVED_SOURCES_DIR "${CMAKE_BINARY_DIR}/DerivedSources")
> 
> This is needed in order to build Gtk too. Mind setting this unconditionally and setting the others using this var? Like this:
> SET(DERIVED_SOURCES_DIR "${CMAKE_BINARY_DIR}/DerivedSources")
> SET(DERIVED_SOURCES_WEBCORE_DIR ${DERIVED_SOURCES_DIR/WebCore)
> SET(DERIVED_SOURCES_JAVASCRIPTCORE_DIR ${DERIVED_SOURCES_DIR/JavaScriptCore)
> 
> and so on
I removed IF condition.

> 
> > Source/WebKit2/CMakeLists.txt:410
> > +SET(WebKit2_MESSAGES_IN_FILES
> > +    ${WEBKIT2_DIR}/UIProcess/WebMediaCacheManagerProxy.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/WebCookieManagerProxy.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/Plugins/PluginProcessProxy.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/WebInspectorProxy.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/WebFullScreenManagerProxy.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/WebDatabaseManagerProxy.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/WebPageProxy.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/WebIconDatabase.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/Downloads/DownloadProxy.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/WebContext.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/WebGeolocationManagerProxy.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/DrawingAreaProxy.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/WebKeyValueStorageManagerProxy.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/WebResourceCacheManagerProxy.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/WebProcessProxy.messages.in
> > +    ${WEBKIT2_DIR}/UIProcess/WebApplicationCacheManagerProxy.messages.in
> > +    ${WEBKIT2_DIR}/PluginProcess/WebProcessConnection.messages.in
> > +    ${WEBKIT2_DIR}/PluginProcess/PluginControllerProxy.messages.in
> > +    ${WEBKIT2_DIR}/PluginProcess/PluginProcess.messages.in
> > +    ${WEBKIT2_DIR}/Shared/Plugins/NPObjectMessageReceiver.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/MediaCache/WebMediaCacheManager.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/Plugins/PluginProxy.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/WebProcess.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/Geolocation/WebGeolocationManager.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/WebCoreSupport/WebDatabaseManager.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/IconDatabase/WebIconDatabaseProxy.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/Authentication/AuthenticationManager.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/ResourceCache/WebResourceCacheManager.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/FullScreen/WebFullScreenManager.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/Cookies/WebCookieManager.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/KeyValueStorage/WebKeyValueStorageManager.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/WebPage/WebPage.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/WebPage/WebInspector.messages.in
> > +    ${WEBKIT2_DIR}/WebProcess/WebPage/DrawingArea.messages.in
> > +)
> 
> Since we are already in WebKit2 subdir, I think it's better not to keep the ${WEBKIT2_DIR} prefix.
> 
> If you need it after in ADD_CUSTOM_COMMAND, use the WORKING_DIRECTORY setting.
Thanks, I did.

> 
> > Source/WebKit2/CMakeLists.txt:436
> > +SET(WebProcess_NAME ../Programs/WebProcess)
> > +SET(WebProcess_SOURCES "")
> > +
> > +SET(WebProcess_LIBRARIES
> > +    ${JavaScriptCore_LIBRARY_NAME}
> > +    ${WebCore_LIBRARY_NAME}
> > +    ${WebKit2_LIBRARY_NAME}
> > +)
> 
> Did you forget to add the sources?
No, WebProcess only requires platform specific one files.

> 
> > Source/WebKit2/CMakeLists.txt:452
> > +ADD_DEFINITIONS(-DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1)
> > +
> 
> Shouldn't this be specific to EFL?
Right, I removed.
Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.