[Webkit-unassigned] [Bug 48297] Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.image.destination-atop.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48297





--- Comment #10 from Julien Chaffraix <jchaffraix at webkit.org>  2011-06-09 17:22:21 PST ---
> I have used the same test case LayoutTests/canvas/philip/tests/2d.composite.uncovered.image.destination-atop.html & modified it to source-atop(changed only this line ctx.globalCompositeOperation = 'source-atop';). 
> 
> When I verified this behavior in both FF & Safari, the source-atop & destination-atop behaviors were different & as per my understanding from the spec for these two test cases, the behaviors should be different.

I confirm that we have a difference between source-atop and destination-atop that is not present in any other browser.

> > Also if you change the behavior for source-atop, shouldn't fast/canvas/canvas-composite-alpha.html need a rebaseline too?
> 
> So, without my changes, source-atop works the same way in Safari, FF & Opera, i.e. no code changes required. In my opinion, we should only fix the destination-atop issue for WebKit code.

Sorry, I meant destination-atop in my question. I tried your patch and it does work properly, however I see the need for a rebaseline on Qt at least. I am not sure why it is not picked up by the chromium EWS as chromium does not have the right behavior.

Rethinking over the difference in behavior, I don't see a good way around that. Could you please amend the comment about source-atop explaining why destination-atop needs the "display transparency everywhere".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.