[Webkit-unassigned] [Bug 61495] Make RenderStyle visuallyOrdered property use an enum instead of a bool.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61495





--- Comment #15 from Luke Macpherson <macpherson at chromium.org>  2011-06-09 17:15:46 PST ---
(In reply to comment #14)
> (In reply to comment #12)
> > > Source/WebCore/rendering/RenderBlockLineLayout.cpp:964
> > > +            VisualDirectionOverride override = (style()->rtlOrdering() == VisualOrder ? (style()->direction() == LTR ? VisualLeftToRightOverride : VisualRightToLeftOverride) : NoVisualOverride);
> > 
> > What!?  We have a 4th way to express the same concept?
> 
> I guess this 4th one is a ternary not just a bool... but I expect CSS has the same thing.  auto, LTR or RTL.  I'm not sure what VisualLeftToRightOverride really means.

(In reply to comment #13)
> I would let mitz have a chance to comment before we mark this cq+.  It's possible he may think this only makes the problem of this bool confusion worse.

Is 4 days enough time?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.