[Webkit-unassigned] [Bug 62347] [EFL] Add load error handler to EWebLauncher

Thu Jun 9 15:57:03 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=62347

--- Comment #4 from Jaehun Lim <ljaehun.lim at samsung.com>  2011-06-09 15:57:04 PST ---
(In reply to comment #2)
> (From update of attachment 96530 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96530&action=review
> 
> Just some minor nitpicks. Otherwise, LGTM.
> 
> > Tools/ChangeLog:9
> > +        Add a handler function of "load,error" to EWebLauncher.
> > +        EWebLauncher can show a simple error page when load error.
> 
> I think something along the lines of "EWebLauncher now displays a simple error page on load errors." would be better.
> 
> > Tools/EWebLauncher/main.c:321
> > +    snprintf(message, 1024, "<html><body><div style=\"color:#ff0000\">ERROR !</div><br><div>Code : %d<br>Domain : %s<br>Description : %s<br>URL : %s</div></body</html>",
> 
> No spaces before punctuation. Use "ERROR!", "Code:", etc.

Thanks for your comments. I uploaded a new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.