[Webkit-unassigned] [Bug 61205] Web Inspector: Cache XHR content in backend, do not use initialContentSet for XHRs.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61205





--- Comment #19 from Andrey Kosyakov <caseq at chromium.org>  2011-06-09 11:24:22 PST ---
(From update of attachment 96596)
View in context: https://bugs.webkit.org/attachment.cgi?id=96596&action=review

> Source/WebCore/inspector/NetworkResourcesData.cpp:88
> +    if (ensureFreeSpace(content.length()) && !resourceData->isContentDeleted) {

I'd rather reverse the order of these checks  -- otherwise we may try to purge some useful data to make space for resource data we won't save anyway.

> Source/WebCore/inspector/NetworkResourcesData.cpp:125
> +    for (it = m_identifierToResourceDataMap.begin(); it != end; ++it) {
> +        ResourceData* resourceData = it->second;
> +        if (!preservedLoaderId.isNull() && resourceData->loaderId == preservedLoaderId)
> +            preservedMap.set(it->first, it->second);
> +    }

So we don't delete actual resource data that we discard from the map. Looks like a leak!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.