[Webkit-unassigned] [Bug 12073] Implement setCurrentTime() and pauseAnimations() on SVGSVGElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=12073


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |krit at webkit.org




--- Comment #8 from Dirk Schulze <krit at webkit.org>  2011-06-09 08:40:57 PST ---
(In reply to comment #7)
> (From update of attachment 67423 [details])
> Hi Chris,
> 
> > +void SMILTimeContainer::setElapsed(SMILTime time)
> > +{
> > +    m_beginTime = currentTime() - time.value();
> > +    m_accumulatedPauseTime = 0;
> > +    if (isPaused()) {
> > +        SMILTime elapsed = this->elapsed();
> > +        updateAnimations(elapsed);
> > +    }
> No need for a local variable, just use:
> if (isPaused())
>     updateAnimations(elapsed());
> 
> You have to write tests and a ChangeLog, please use prepare-ChangeLog in your root WebKit directory to generate templates. r-, until these issues are resolved. The patch itself looks just fine, but you'll need to write several testcases, ideally using the existing framework in LayoutTests/svg/animations.
> Test it using accumulative animations, normal ones, etc.
> 
> Thanks in advance!

It's pretty hard to test is within our current animation DRT api, since the hack for this framework tries to do the same thing. So we can't test setCurrentTime that stes the current time as well. I'd suggest to remove the current hack and use setCurrentTime instead. This way our animation framework would get browser independent and we have dozens of tests for setCurrentTime. What do you think Niko?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.