[Webkit-unassigned] [Bug 62363] [EFL][WK2] Add PageClientImpl and WebPageProxyEfl for efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62363





--- Comment #5 from Leandro Pereira <leandro at profusion.mobi>  2011-06-09 07:03:32 PST ---
(From update of attachment 96565)
View in context: https://bugs.webkit.org/attachment.cgi?id=96565&action=review

As with other WebKit2 patches, I'm mostly reviewing for style/EFL usage issues.

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:73
> +#define USE_EWK_TOUCH 1
> +#if USE_EWK_TOUCH
> +    evas_object_move(m_viewObject, 0, 0);
> +#endif

Why this #define/#if?

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:229
> +void PageClientImpl::findStringInCustomRepresentation(const String&, FindOptions, unsigned maxMatchCount)

maxMatchCount isn't used. Omit its name. There are other unused parameters that should have its name omitted as well, please review them.

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:53
> +    virtual void scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset);

No need to add parameter names on prototypes.

> Source/WebKit2/UIProcess/WebPageProxy.h:668
> -#if PLATFORM(GTK)
> +#if PLATFORM(GTK) || PLATFORM(EFL)
>      void getEditorCommandsForKeyEvent(Vector<String>&);
>  #endif

This function is just a stub below; do we really need the stub and this change here?

> Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp:51
> +#if PLATFORM(X11)
> +    platform = "X11";
> +#else
> +    platform = "Unknown";
> +#endif

Since Evas/Ecore allows you to use other backends without recompiling your program, this will fail. If the result of WebPageProxy::standardUserAgent() is cached somewhere, it would be nicer if the Evas backend could be queried in runtime. If not, you can leave it like this, as this is unlikely to impact anything anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.