[Webkit-unassigned] [Bug 62347] [EFL] Add load error handler to EWebLauncher

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 9 06:54:57 PDT 2011


--- Comment #2 from Leandro Pereira <leandro at profusion.mobi>  2011-06-09 06:54:57 PST ---
(From update of attachment 96530)
View in context: https://bugs.webkit.org/attachment.cgi?id=96530&action=review

Just some minor nitpicks. Otherwise, LGTM.

> Tools/ChangeLog:9
> +        Add a handler function of "load,error" to EWebLauncher.
> +        EWebLauncher can show a simple error page when load error.

I think something along the lines of "EWebLauncher now displays a simple error page on load errors." would be better.

> Tools/EWebLauncher/main.c:321
> +    snprintf(message, 1024, "<html><body><div style=\"color:#ff0000\">ERROR !</div><br><div>Code : %d<br>Domain : %s<br>Description : %s<br>URL : %s</div></body</html>",

No spaces before punctuation. Use "ERROR!", "Code:", etc.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list