[Webkit-unassigned] [Bug 61915] [EFL][WK2] Add efl port's ewk_view files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61915





--- Comment #18 from EunMi Lee <eunmi15.lee at samsung.com>  2011-06-09 06:38:46 PST ---
(In reply to comment #16)
> (From update of attachment 96561 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96561&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:43
> > +#ifndef EWK_TYPE_CHECK
> > +#define EWK_VIEW_TYPE_CHECK(o, ...) do { } while (0)
> > +#else
> > +#define EWK_VIEW_TYPE_CHECK(o, ...)                                     \
> 
> Shouldnt this be in some common header file?

The EWK_VIEW_TYPE_CHECK is used before getting evas_object_smart_data,
and evas_object_smart_data is used only in the ewk_view.
So, I think that we can leave that macro in the cpp file.

Anyway, I modified some codes in the new patch.

1. remove EWK_TYPE_CHECK
+#ifndef EWK_TYPE_CHECK
Adding above ifndef is my mistake.
I copied that code from WebKit1's ewk_view but it is not used in the WebKit2's ewk_view.
So, I have removed above ifndef from the code.

2. add EWK_TYPE_CHECK for EWK_VIEW_SD_GET
EWK_TYPE_CHECK was done only in the EWK_VIEW_SD_GET_OR_RETURN.
So, I have added EWK_TYPE_CHECK for EWK_VIEW_SD_GET too.

3. add eina_log_domain
I have added variable _ewk2_log_dom for eina_log_domain.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.