[Webkit-unassigned] [Bug 62366] [GTK] Support authentication dialogs in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62366


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-06-09 04:22:07 PST ---
Attachment 96571 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:48:  web_auth_dialog_get_type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:55:  web_auth_dialog_class_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:59:  web_auth_dialog_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/gtk/GtkAuthenticationDialog.cpp:71:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 4 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.