[Webkit-unassigned] [Bug 62366] [GTK] Support authentication dialogs in WebKit2

Thu Jun 9 03:56:14 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=62366

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96570|                            |review?
               Flag|                            |

--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-06-09 03:56:14 PST ---
Created an attachment (id=96570)
 --> (https://bugs.webkit.org/attachment.cgi?id=96570&action=review)
Patch

This patch moves the common code to show an auth dialog from webkitsoupauthdialog to a new C++ class in WebCore. In WebKit1 webkitsoupauthdialog has been converted into a C++ file with the same interface, since it's public in the api, and it simply contains the soup feature interface implementation using the new GtkAuthenticationDialog class. In WebKit2 I added the soup feature interface impemlentation to WebProcess/gtk/WebProcessMainGtk.cpp since it's very simple, but I can move it into its own file if you think it's better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.