[Webkit-unassigned] [Bug 60059] AssociatedURLLoader reports some errors synchronously

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60059


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96517|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #24 from Adam Barth <abarth at webkit.org>  2011-06-08 23:37:31 PST ---
(From update of attachment 96517)
View in context: https://bugs.webkit.org/attachment.cgi?id=96517&action=review

Thanks for writing the test.  I appreciate it.  One nit below and this looks good to go.

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:191
> +    ASSERT(timer);

Normally, we do the following:

ASSERT_UNUSED(timer == &m_errorTimer, timer);

Some configurations of WebKit generate compile errors for unused variables.  In your patch |timer| is unused in release builds.  Also, the ASSERT above is more precise because it makes sure |timer| points to the object we expect.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.