[Webkit-unassigned] [Bug 60964] Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 8 11:36:39 PDT 2011


--- Comment #11 from Tom Hudson <tomhudson at google.com>  2011-06-08 11:36:39 PST ---
(In reply to comment #9)
> (In reply to comment #7)
> > The intent was to have a bit of UI memory; if we change from looking at IMAGE to TEXT failure cases, and then back, we restore the sortedness/unsortedness from before.
> Right, but if you only do the sorting (currently at lines 264 to 268) inside the selectedTypeIsSortableBranch (line 258), then I don't think you need to touch shouldSortTestsByMetric in enable/DisableSorting, hence you don't need wasSortingTestsByMetric.

Actually, the sorting currently checks selectedTypeIsSortable && shouldSortByMetric, so it doesn't even need to be moved, but I went ahead and moved it to condense two consecutive similar conditionals.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list