[Webkit-unassigned] [Bug 62260] [CMAKE][WK2] Add an option to build webkit2.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62260





--- Comment #8 from Ryuan Choi <ryuan.choi at samsung.com>  2011-06-08 08:40:12 PST ---
(In reply to comment #5)
> (From update of attachment 96407 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96407&action=review
> 
> > Source/CMakeLists.txt:16
> > +    SET(ENABLE_WEBKIT )
> 
> IMHO a MESSAGE(FATAL_ERROR "config error....") whould be better here.
> 
Hmm, Is it better to keep Webkit as a default for convenience?
IMO, Other engineers, who may not know webkit2, doesn't need to learn new option to build.

> > Source/CMakeLists.txt:29
> > +    SET(DERIVED_SOURCES_DIR "${CMAKE_BINARY_DIR}/DerivedSources")
> 
> I don't understand this line. How it related to WK2?
> 
I'll check once more.
When I started, WebKit2 required it.
Now I'm not sure.

> > Source/CMakeLists.txt:101
> > +IF (ENABLE_WEBKIT)
> > +    SET(WebKit_LIBRARY_NAME WebKit)
> > +ENDIF ()
> > +
> > +IF (ENABLE_WEBKIT2)
> > +    SET(WebKit2_LIBRARY_NAME WebKit2)
> > +ENDIF ()
> 
> I don't see a problem in setting this variables all the time. This will make the configuration much simpler.
> (the same applies to the other similar changes too)
Done.

> 
> > Source/WebKit2/CMakeLists.txt:94
> > +SET(WebKit2_SOURCES
> 
> Please add an empty line when the containig folder changes like we do at the other files: e.g. after "Platform/CoreIPC" to "Plaform", or "Platform" to "PluginProcess".
> This makes the long lines a little bit easier to read.
Thank you, I did.

> 
> > Source/WebKit2/CMakeLists.txt:410
> > +SET (WebProcess_NAME ../Programs/WebProcess)
> > +SET (WebProcess_SOURCES "")
> > +
> > +SET (WebProcess_LIBRARIES
> 
> Please removte the space after SET
Done.

> 
> > Source/WebKit2/CMakeLists.txt:441
> > +
> 
> Is there an unneded empty line at the end?
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.