[Webkit-unassigned] [Bug 61000] Control Indexeddb backends from LayoutTestController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61000





--- Comment #28 from Greg Simon <gregsimon at chromium.org>  2011-06-08 07:14:31 PST ---
(In reply to comment #27)
> (From update of attachment 96256 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96256&action=review
> 
> > Source/WebCore/storage/IDBFactoryBackendImpl.cpp:90
> > +        // Migrationp
> 
> this comment doesn't add much value
> 
> > Source/WebCore/storage/IDBFactoryBackendImpl.cpp:95
> > +            backingStoreType = LevelDBBackingStore;
> 
> I don't like that we override the backingStoreType. I think we should only migrate if backingStoreType == LevelDBBackingStore.
> 
> This in fact will break the layout tests. After the migration test, hasLeveLDBBackingStore will be true, so any subsequent layout tests run in the same process will use LevelDB, which is not intended (they don't all pass with LevelDB at the moment).

This will not break the layout tests because the backend can be controlled from LayoutTestController. This is the point of this patch actually -- so you can set things up from individual layout tests to force migrations. 

If you look at the changes to WebIDBFactoryImpl.cpp there is a comment explaining how this works.

With this patch and the migration code patch I am able to run through the (unchanged) indexeddb tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.