[Webkit-unassigned] [Bug 61423] [EFL] Eina_List out of memory handling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61423





--- Comment #11 from Grzegorz <g.czajkowski at samsung.com>  2011-06-08 01:54:47 PST ---
(In reply to comment #10)
> (From update of attachment 96247 [details])
> 
> 
> Are you going to test each OOM condition?

It's already done but only in simply scenario. Do you really think that we should not check in this case?
When I try to skip NULL checking in loops my review was denied. I had to use goto instruction. Instead of that I would use ewk_util_oom_handling.

"Never think to write malloc-fail-proof code without testing it thoroughly, otherwise you haven’t written malloc-fail-proof code".

Yes, it was tested. I assigned 0 to some part of code in ewk_cookies_all_get().

> 
> If you really want to debug these situations, the best place to check for them is inside Eina (since you are talking about eina_list_append), not inside webkit.
> 

>From Eina's documentation:
 list = eina_list_prepend(list, my_data);
 if (eina_error_get())
   {
     fprintf(stderr, "ERROR: Memory is low. List allocation failed.\n");
     exit(-1);

I think we do not want this inside Eina ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.