[Webkit-unassigned] [Bug 61324] --webkit-visual-word does not work well in words separated by multiple spaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61324


Xiaomei Ji <xji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96316|0                           |1
        is obsolete|                            |
  Attachment #96316|review?                     |
               Flag|                            |
  Attachment #96330|                            |review?
               Flag|                            |




--- Comment #15 from Xiaomei Ji <xji at chromium.org>  2011-06-07 17:03:14 PST ---
Created an attachment (id=96330)
 --> (https://bugs.webkit.org/attachment.cgi?id=96330&action=review)
patch w/ layout test

(In reply to comment #14)
> (From update of attachment 96316 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96316&action=review
> 
> > Source/WebCore/ChangeLog:17
> > +        wrong for words separated by multiple spaces. For example, given words A and B separated by 
> 
> You should probably state why it's wrong.

I used an example to explain since I feel it is not easy to explain without an example.

> 
> > Source/WebCore/ChangeLog:20
> > +        position after current word. But positionBeforeNextWord and positionAfterPreviousWord only 
> > +        take care of case "A|".
> 
> Instead of what positionBeforeNextWord can do, you should state what it gets wrong.

How about?

 For example, given words A and B separated by
        3 continuous spaces "A   B", position "A|", "A |", and "A  |" should all be considered as
        position after current word. But for position "A |", its previousWordPosition's
        nextWordPosition is position "A|", which is different from its current position, so the
        current position is not considered as a position after current word, consequently,
        instead of returning the right position as "A   |B", positionBeforeNextWord returns the
        position before next next word, as "A   B |C". Similar happens for position "A  |".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.