[Webkit-unassigned] [Bug 62222] JSStaticFunction and JSStaticValue are overly "const"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62222


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96270|review+, commit-queue+      |review-, commit-queue-
               Flag|                            |




--- Comment #5 from Geoffrey Garen <ggaren at apple.com>  2011-06-07 14:59:58 PST ---
(From update of attachment 96270)
Oops!

The Windows EWS bot failed to compile, and showing this warning, which illustrates a real bug in your code:

7>c:\cygwin\home\buildbot\webkit\source\javascriptcore\api\tests\testapi.c(943) : error C2220: warning treated as error - no 'object' file generated
7>c:\cygwin\home\buildbot\webkit\source\javascriptcore\api\tests\testapi.c(943) : warning C4700: uninitialized local variable 'fun' used
7>c:\cygwin\home\buildbot\webkit\source\javascriptcore\api\tests\testapi.c(945) : warning C4700: uninitialized local variable 'val' used

You can't just declare "fun" as a pointer -- you need to point to something. I'd suggest changing this to declare fun and val as variables on the stack.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.