[Webkit-unassigned] [Bug 54417] [chromium] Add a basic gesture recognizer to the Chromium platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54417





--- Comment #33 from Robert Kroeger <rjkroege at chromium.org>  2011-06-07 14:37:38 PST ---
(From update of attachment 95759)
View in context: https://bugs.webkit.org/attachment.cgi?id=95759&action=review

>>> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:92
>>> +    m_edgeFunctions.add(signature(state, fingerId, touchType, touchHandledByJavaScript), f);
>> 
>> A full variable name would be nice instead of "f".
> 
> A full variable name would be nice instead of "f".

done in merge conflict patch

>>> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:158
>>> +// 1 LSB bit for signature >= 1
>> 
>> This is a bit unclear.
> 
> This is a bit unclear.

done.

>>> Source/WebCore/platform/chromium/GestureRecognizerChromium.h:48
>>> +    };
>> 
>> Is the indent right here?
> 
> Is the indent right here?

no. fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.