[Webkit-unassigned] [Bug 54417] [chromium] Add a basic gesture recognizer to the Chromium platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54417


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95759|review?                     |review+
               Flag|                            |




--- Comment #29 from Benjamin Poulain <benjamin at webkit.org>  2011-06-07 10:12:37 PST ---
(From update of attachment 95759)
View in context: https://bugs.webkit.org/attachment.cgi?id=95759&action=review

Yep, I like it.
I think the test will evolve a bit (kinetic scrolling, frames, block + overflow) but that is a good start.

Some comments:

> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:92
> +void InnerGestureRecognizer::addEdgeFunction(State state, unsigned fingerId, PlatformTouchPoint::State touchType, bool touchHandledByJavaScript, GestureTransitionFunction f)
> +{
> +    m_edgeFunctions.add(signature(state, fingerId, touchType, touchHandledByJavaScript), f);

A full variable name would be nice instead of "f".

> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:158
> +// 1 LSB bit for signature >= 1

This is a bit unclear.

> Source/WebCore/platform/chromium/GestureRecognizerChromium.h:48
> +    enum State {
> +      NoGesture,
> +      PendingSyntheticClick,
> +      Scroll
> +    };

Is the indent right here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.