[Webkit-unassigned] [Bug 62200] [GTK] Move moduleMixesGtkSymbols() from PluginPackage to PluginView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62200


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org




--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2011-06-07 09:19:57 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 96225 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=96225&action=review
> > 
> > The bits in WebKit2 look good, but it seems we don't really need to move any WebKit1 code around for this change. Do you mind undoing that bit of the patch?
> 
> We need to be able to load the plugin even if it mixes gtk symbols in webkit2. To load the plugin and get the info the ui process uses PluginPackage. The problem of mixing symbols is in the view, that uses gtk. If we leave the check in PlugionPackage the ui process won't be able to load the plugin and the plugin process will never be launched.

Okay. Do you mind expanding the ChangeLog to mention that PluginPackage::load is used by both WebKit1 and WebKit2, so this necessitates moving the check?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.