[Webkit-unassigned] [Bug 48578] HTML5 Conformance Test failure: approved/canvas/canvas_text_font_001.htm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48578


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96217|review?                     |review-
               Flag|                            |




--- Comment #20 from Eric Seidel <eric at webkit.org>  2011-06-07 08:48:24 PST ---
(From update of attachment 96217)
I don't understand why we need to remove/append to substrings for your algorithm to work.

Isn't it just:

while (start < end) {
  if (isSpaceOrNewLine(*start))
     continue;
   bool equalIgnoringCase(start, "inherit") || equalIgnoringCase(start, "initial") {
      start += 6;
      if (start == end || isSpaceOrNewline(start))
          return true;
   }
}

That's not quite real code because I'm not updating start quite correctly.  But that's the idea.

If we don't have an elegant way to write this, I'm not sure it should be written.  This is a very low-priority fix.
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.