[Webkit-unassigned] [Bug 48297] Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.image.destination-atop.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 6 20:15:29 PDT 2011


--- Comment #8 from Julien Chaffraix <jchaffraix at webkit.org>  2011-06-06 20:15:28 PST ---
(In reply to comment #3)
> (From update of attachment 95887 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95887&action=review
> > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1513
> >      // CompositeSourceAtop is not listed here as the platforms already implement the specification's behavior.
> This comment no longer makes sense.

I disagree, it still makes sense. CompositeSourceAtop is marked as needed transparency everywhere else in the spec. However the platforms already implement the right behavior, thus there is no need to re-do the work here.

I am quite concerned with having different behaviors for source-atop vs destination-atop. If your testing shows that this change is needed, I would rather remove the comment and make sure both work the same.

Also if you change the behavior for source-atop, shouldn't fast/canvas/canvas-composite-alpha.html need a rebaseline too?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list