[Webkit-unassigned] [Bug 61993] [EFL][WK2] add WebKit2 EFL port's NativeWebMouseEvent and NativeWebWheelEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61993





--- Comment #4 from EunMi Lee <eunmi15.lee at samsung.com>  2011-06-06 19:19:34 PST ---
(In reply to comment #2)
> (From update of attachment 95856 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95856&action=review
> 
> I know nothing about WebKit2, but I can comment about some style issues.
> 
> > Source/WebKit2/Shared/efl/NativeWebMouseEventEfl.cpp:37
> > +NativeWebMouseEvent::NativeWebMouseEvent(const Evas_Event_Mouse_Down* event, const Evas_Point* position)
> > +    : WebMouseEvent(WebEventFactory::createWebMouseEvent(event, position))
> > +    , m_nativeEvent(event)
> > +{
> > +}
> 
> notImplemented();
> 
Those are all codes for NativeWebMouseEvent::NativeWebMouseEvent.
There is nothing to implement more.

> > Source/WebKit2/Shared/efl/NativeWebMouseEventEfl.cpp:43
> > +NativeWebMouseEvent::NativeWebMouseEvent(const Evas_Event_Mouse_Up* event, const Evas_Point* position)
> > +    : WebMouseEvent(WebEventFactory::createWebMouseEvent(event, position))
> > +    , m_nativeEvent(event)
> > +{
> > +}
> 
> notImplemented();
> 
Ditto.

> > Source/WebKit2/Shared/efl/NativeWebMouseEventEfl.cpp:49
> > +NativeWebMouseEvent::NativeWebMouseEvent(const Evas_Event_Mouse_Move* event, const Evas_Point* position)
> > +    : WebMouseEvent(WebEventFactory::createWebMouseEvent(event, position))
> > +    , m_nativeEvent(event)
> > +{
> > +}
> 
> notImplemented();
>
Ditto.

> > Source/WebKit2/Shared/efl/NativeWebWheelEventEfl.cpp:37
> > +NativeWebWheelEvent::NativeWebWheelEvent(const Evas_Event_Mouse_Wheel* event, const Evas_Point* position)
> > +    : WebWheelEvent(WebEventFactory::createWebWheelEvent(event, position))
> > +    , m_nativeEvent(event)
> > +{
> > +}
> 
> notImplemented();
> 
Ditto.

> > Source/WebKit2/Shared/efl/WebEventFactory.cpp:52
> > +    return (WebEvent::Modifiers)result;
> 
> Use C++-style cast.
> 
I've changed code to use C++ style cast.

> > Source/WebKit2/Shared/efl/WebEventFactory.h:43
> > +
> 
> Whereis the #endif?

The #endif exists in the line 44 :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.