[Webkit-unassigned] [Bug 62164] Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 6 17:53:31 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=62164


Dmitry Titov <dimich at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96159|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #9 from Dmitry Titov <dimich at chromium.org>  2011-06-06 17:53:31 PST ---
(From update of attachment 96159)
Adam has inspired me to do a better review :-)

Lets indeed remove all pieces that are not needed anymore:
- Comment in DOMDataStore.cpp, that explains threading considerations should be updated.
- in V8DOMMap.*, lets rename methods like 'visitActiveDOMObjectsInCurrentThread' to 'visitActiveDOMObjects', since they are not looking at thread anymore.
- As Adam noted, ChildThreadDOMData can go away - but at the same time MainThreadDOMData can go away as well, so there is only single DOMData class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list