[Webkit-unassigned] [Bug 61999] [EFL][WK2] Add an option to build WebKit2.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61999





--- Comment #4 from Ryuan Choi <ryuan.choi at samsung.com>  2011-06-06 17:39:03 PST ---
(In reply to comment #2)
> (From update of attachment 95870 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95870&action=review
> 
> > Source/CMakeLists.txt:20
> > +SET(DERIVED_SOURCES_WEBKIT2_DIR "${CMAKE_BINARY_DIR}/DerivedSources/WebKit2")
> 
> How do you think WebKit 2 variables are only set when WEBKIT2 is enabled ?

If then, we should check webkit2 option at front of Source/CMakeLists.txt.
cmake/WebKitFS.cmake should know that DERIVED_SOURCES_WEBKIT2_DIR.

If it's not harmful, I like it as default.


(In reply to comment #3)
> (From update of attachment 95870 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95870&action=review
> 
> > Source/CMakeLists.txt:125
> >  ADD_SUBDIRECTORY(WebKit)
> > +IF (ENABLE_WEBKIT2)
> > +    ADD_SUBDIRECTORY(WebKit2)
> > +ENDIF ()
> 
> WebKit always be built if one only wants WebKit2. Is this the expected behaviour?
> 
I'll change not to build webkit when WebKit2 was enabled.
My first patch is exactly what I want like WebKit2/Gtk.
But now, we don't have any requirements for that.
So, only one library for webkit2 looks fine.

> > Source/CMakeLists.txt:133
> > +IF (ENABLE_WEBKIT2)
> > +    INCLUDE_IF_EXISTS(${TOOLS_DIR}/MiniBrowser/${WEBKIT_PORT_DIR}/CMakeLists${PORT}.txt)
> > +ENDIF ()
> 
> I'd change Tools/CMakeListsEfl.txt instead.
Ok. If then, I'll remove it and it will be covered by Bug 61850

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.