[Webkit-unassigned] [Bug 61946] FrameLoaderClient::didRunInsecureContent - no way to distinguish between blocked/run cases.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 6 15:25:39 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61946


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96137|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #15 from Adam Barth <abarth at webkit.org>  2011-06-06 15:25:39 PST ---
(From update of attachment 96137)
View in context: https://bugs.webkit.org/attachment.cgi?id=96137&action=review

We could add a Chromium WebKit API test to show that the overrides work.  You can look at how we test the other allow methods, if you want some inspiration.

> Source/WebCore/loader/FrameLoader.cpp:1119
> +    bool allowedPerSettings = settings && settings->allowDisplayOfInsecureContent();
> +    bool allowed = m_client->allowDisplayingInsecureContent(allowedPerSettings);

I'd just inline the settings && settings->allowDisplayOfInsecureContent() expression into the client call and get rid of the temporary, but that's just a style nit.

> Source/WebCore/loader/FrameLoader.cpp:1126
> -    m_client->didDisplayInsecureContent();
> +    if (allowed)
> +        m_client->didDisplayInsecureContent();

I'd send the URL through too.

> Source/WebCore/loader/FrameLoaderClient.h:301
> +        virtual bool allowDisplayingInsecureContent(bool enabledPerSettings) { return enabledPerSettings; }

No URL here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list