[Webkit-unassigned] [Bug 62149] Web Inspector: [Chromium] DevTools does not highlight elements when accelerated compositing is on.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62149


Vangelis Kokkevis <vangelis at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96124|review-                     |review?
               Flag|                            |




--- Comment #4 from Vangelis Kokkevis <vangelis at chromium.org>  2011-06-06 15:10:55 PST ---
(From update of attachment 96124)
View in context: https://bugs.webkit.org/attachment.cgi?id=96124&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:90
> +        hudSize.setWidth(m_layerRenderer->viewportSize().width());

still need to clamp to the max texture size .  An example can be found in DrawingBuffer::reset() (DrawingBuffer.cpp)

> Source/WebKit/chromium/src/PageOverlay.cpp:84
> +    if (!m_viewImpl->isAcceleratedCompositingActive()) {

isAcceleratedCompositingActive() needs to be protected by USE(ACCELERATED_COMPOSITING) guards.

> Source/WebKit/chromium/src/PageOverlay.cpp:105
> +void PageOverlay::webFramePainted(GraphicsContext& gc)

The method should probably be named using an active verb.  paintWebFrame ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.