[Webkit-unassigned] [Bug 61207] [Qt] Export files under Symbian Qt WebKit build

Mon Jun 6 13:26:13 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=61207

Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94681|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #20 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2011-06-06 13:26:13 PST ---
(From update of attachment 94681)
View in context: https://bugs.webkit.org/attachment.cgi?id=94681&action=review

r- because of the change in WebKit.pri. Janne's proposal seems to be a "cleaner" way to do address this issue, so we should understand better why Janne's proposal would not work before we proceed with this approach.

>> Source/WebKit.pri:27
>> +isEmpty(OUTPUT_DIR): OUTPUT_DIR = $$PWD
> 
> Why is this needed in the .pri file?
> 
> I thought it belongs into the .pro files, and QtWebKit.pro has it indeed.

I agree that this needs to be removed; so will r- for now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.