[Webkit-unassigned] [Bug 54562] Web Inspector: remove platform specifics from node highlight routines.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54562


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95477|review?                     |review-
               Flag|                            |




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-06-06 07:56:53 PST ---
(From update of attachment 95477)
View in context: https://bugs.webkit.org/attachment.cgi?id=95477&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1474
> +    } else if (graphicsLayer == m_overlayLayer)
> +        m_renderView->frameView()->frame()->page()->pageOverlay()->paintComposited(context);

This is just too convoluted. RLC shouldn't have to know anything about page()->pageOverlay().

I still think that the overlay layer should be hooked up outside of WebCore, just like WK2 does it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.