[Webkit-unassigned] [Bug 62118] Use of ENABLE(INSPECTOR) is inconsistent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62118





--- Comment #5 from Yury Semikhatsky <yurys at chromium.org>  2011-06-06 05:07:56 PST ---
(In reply to comment #4)
> > Also, I'd rather keep all guards in ScriptProfiler.cpp
> So we should guard the contents of ScriptProfiler::initialize()?
> 
I'd do so, but I don't mind if you leave the guard at the call site as well. We regularly place guards at call sites and around whole implementation of the class but I think it won't work in this case as part of ScriptProfiler should be available when inspector is disabled.

> The problem is that I can't compile ScriptProfiler without also compiling ScriptProfile, but this requires InspectorObject, which is guarded by ENABLE(INSPECTOR). Should all of other methods of ScriptProfiler be guarded by EANBLE(INSPECTOR)?
Yes, all methods that are only used by inspector should be guarded by ENABLE(INSPECTOR), this should make ScriptProfiler compile even when inspector is disabled.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.