[Webkit-unassigned] [Bug 62118] Use of ENABLE(INSPECTOR) is inconsistent

Mon Jun 6 04:34:46 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=62118

Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96074|review?                     |review-
               Flag|                            |

--- Comment #3 from Yury Semikhatsky <yurys at chromium.org>  2011-06-06 04:34:46 PST ---
(From update of attachment 96074)
View in context: https://bugs.webkit.org/attachment.cgi?id=96074&action=review

> Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:301
> +#if ENABLE(INSPECTOR)

If ScriptProfiler call is guarded with ENABLE(INSPECTOR) here then corresponding part of ScriptProfiler implementation should also be guarded, r- for this.

Also, I'd rather keep all guards in ScriptProfiler.cpp

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.