[Webkit-unassigned] [Bug 62118] New: Use of ENABLE(INSPECTOR) is inconsistent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62118

           Summary: Use of ENABLE(INSPECTOR) is inconsistent
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: steveblock at google.com
                CC: pfeldman at chromium.org, mnaganov at chromium.org


Android does not enable INSPECTOR and this results in build errors after http://trac.webkit.org/changeset/81265

http://trac.webkit.org/changeset/81265 added a call to ScriptProfiler::initialize() from V8DOMWindowShell::initContextIfNeeded() (see also Bug 62014). ScriptProfiler requires ScriptProfile, which in turn depends upon InspectorObject. InspectorObject is provided in InspectorValues.h, but the contents are guarded with ENABLE(INSPECTOR), which Android does not enable.

We could simply guard the call to ScriptProfiler::initialize() from V8DOMWindowShell::initContextIfNeeded() with ENABLE(INSPECTOR), or fix what seems to be a more general problem with the use of ENABLE(INSPECTOR).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.