[Webkit-unassigned] [Bug 62098] Update layout for msub, msup, msubsup to handle script changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62098





--- Comment #14 from Alex Milowski <alex at milowski.com>  2011-06-05 12:22:40 PST ---
(In reply to comment #13)
> (In reply to comment #12)
> > (In reply to comment #11)
> > > (From update of attachment 96050 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=96050&action=review
> > > 
> > > > Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp:66
> > > > +    unsigned int position = 0;
> > > 
> > > unsigned int is wrong for WebKit style. We use just unsigned.
> > 
> > OK.  That passed the style check script.  I don't see that on the style guide.
> > 
> 
> Neither the style guide nor the style-checker is 100% comprehensive, and we could and should fix that over time. In the meantime, maintaining a stylistically consistent codebase is the best way to have many people hacking on it at once without it turning into a messy jumble of hard-to-read and inconsistent code.

Be that as it may, without either one being up-to-date, people like myself can't know that.  As a result, you'll get inconsistent code.  This is a very frustrating process for people like myself who work on many different projects in different programming languages where such stylistic preferences feel subjective.  I would prefer that the coding style guidelines are always up to date so there is always a canonical reference.  Since I obviously don't know those preferences, I can't contribute to fixing the guidelines.

I'll update the patch, yet again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.