[Webkit-unassigned] [Bug 48578] HTML5 Conformance Test failure: approved/canvas/canvas_text_font_001.htm

Sun Jun 5 11:39:00 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=48578

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95743|review?                     |review-
               Flag|                            |

--- Comment #17 from Eric Seidel <eric at webkit.org>  2011-06-05 11:39:00 PST ---
(From update of attachment 95743)
You've used a dumpAsText test (which is good!), but I don't think you can actually evaluate on the text output.  As-written, you have to actually look at the pixels of your test to see if it worked.

I think instead you want to be checking what ctx.font returns after you set it to "inherit" to make sure that the set was ignored.  Then you don't even need to draw the strings.

If you look at fast/js/resources/js-test-pre.js (and the many many tests which include this script) you can find a shouldBe function which can be helpful for writing dumpAsText tests.  you can use shouldBe("ctx.font", "40px Times New Roman") to make sure that the font doesn't change when you try to assign it "inherit" etc.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.