[Webkit-unassigned] [Bug 60167] [Qt] [WebGL] implement Qt WebGL extensions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60167





--- Comment #11 from Benjamin Poulain <benjamin at webkit.org>  2011-06-05 08:05:16 PST ---
(From update of attachment 95756)
View in context: https://bugs.webkit.org/attachment.cgi?id=95756&action=review

Small comments:

> Source/WebCore/platform/graphics/qt/Extensions3DQt.cpp:43
> +    const QString extensions = QLatin1String(reinterpret_cast<const char *>(glGetString(GL_EXTENSIONS)));

Shouldn't you use a static_cast here? glGetString return a GLByte* so it should cast fine to char*.

> Source/WebCore/platform/graphics/qt/Extensions3DQt.cpp:44
> +    ASSERT(extensions.isNull());

I don't get this assertion. I guess you haven't tried the code in debug? :)

> Source/WebCore/platform/graphics/qt/Extensions3DQt.cpp:46
> +    m_supportedExtensions = extensions.split(QLatin1String(" "), QString::SkipEmptyParts);

QLatin1Char(' ')?

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:-308
> -#if defined (QT_OPENGL_ES_2)
>      return true;
> -#else
> -    return false;
> -#endif

This change looks strange.
What about stuff like precisions directives in the shader? That does not make GL 2 not GLES compliant?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.